flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7811) Add support for Scala 2.12
Date Wed, 24 Oct 2018 09:48:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662029#comment-16662029
] 

ASF GitHub Bot commented on FLINK-7811:
---------------------------------------

aljoscha commented on a change in pull request #6784: [FLINK-7811] Add support for Scala 2.12
URL: https://github.com/apache/flink/pull/6784#discussion_r227718544
 
 

 ##########
 File path: flink-scala/src/main/scala/org/apache/flink/api/scala/unfinishedKeyPairOperation.scala
 ##########
 @@ -169,13 +165,10 @@ private[flink] class HalfUnfinishedKeyPairOperation[L, R, O](
    * the finished operation.
    */
   def equalTo[K: TypeInformation](fun: KeySelector[R, K]): O = {
+
     val keyType = implicitly[TypeInformation[K]]
-    val keyExtractor = new KeySelector[R, K] {
-      val cleanFun = unfinished.leftInput.clean(fun)
-      def getKey(in: R) = cleanFun.getKey(in)
-    }
     val rightKey = new Keys.SelectorFunctionKeys[R, K](
-      keyExtractor,
+      unfinished.leftInput.clean(fun),
 
 Review comment:
   It doesn't matter, I just need to somehow clean the function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add support for Scala 2.12
> --------------------------
>
>                 Key: FLINK-7811
>                 URL: https://issues.apache.org/jira/browse/FLINK-7811
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Scala API
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message