flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ruidong Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8921) Split code generated call expression
Date Wed, 24 Oct 2018 15:38:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662436#comment-16662436

Ruidong Li commented on FLINK-8921:

[~xueyu] thanks for you contribution, I assign this issue to you if you want fix this.

> Split code generated call expression 
> -------------------------------------
>                 Key: FLINK-8921
>                 URL: https://issues.apache.org/jira/browse/FLINK-8921
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Assignee: Ruidong Li
>            Priority: Major
>              Labels: pull-request-available
> In FLINK-8274 we introduced the possibility of splitting the generated code into multiple
methods in order to exceed the JVMs maximum method size (see also https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.9).
> At the moment we only split methods by fields, however, this is not enough in all case.
We should also split expressions. I suggest to split the operands of a {{RexCall}} in {{org.apache.flink.table.codegen.CodeGenerator#visitCall}}
if we reach a certain threshold. However, this should happen as lazily as possible to keep
the runtime overhead low.

This message was sent by Atlassian JIRA

View raw message