flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10208) Bump mockito to 2.0+
Date Tue, 02 Oct 2018 12:46:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635428#comment-16635428
] 

ASF GitHub Bot commented on FLINK-10208:
----------------------------------------

zentol commented on a change in pull request #6634: [FLINK-10208][build] Bump mockito to 2.21.0
/ powermock to 2.0.0-beta.5
URL: https://github.com/apache/flink/pull/6634#discussion_r221935270
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -123,8 +123,8 @@ under the License.
 		<prometheus.version>0.3.0</prometheus.version>
 		<avro.version>1.8.2</avro.version>
 		<junit.version>4.12</junit.version>
-		<mockito.version>1.10.19</mockito.version>
-		<powermock.version>1.6.5</powermock.version>
+		<mockito.version>2.21.0</mockito.version>
+		<powermock.version>2.0.0-beta.5</powermock.version>
 
 Review comment:
   There's no proper 2.0.0 release yet :/ This is the only version available on maven central,
but it's already used a fair bit.
   
   https://mvnrepository.com/artifact/org.powermock/powermock-core

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Bump mockito to 2.0+
> --------------------
>
>                 Key: FLINK-10208
>                 URL: https://issues.apache.org/jira/browse/FLINK-10208
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Build System, Tests
>    Affects Versions: 1.7.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> Mockito only properly supports java 9 with version 2. We have to bump the dependency
and fix various API incompatibilities.
> Additionally we could investigate whether we still need powermock after bumping the dependency
(which we'd also have to bump otherwise).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message