flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10253) Run MetricQueryService with lower priority
Date Mon, 15 Oct 2018 09:53:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649984#comment-16649984
] 

ASF GitHub Bot commented on FLINK-10253:
----------------------------------------

Clarkkkkk commented on a change in pull request #6839: [FLINK-10253] Run MetricQueryService
with lower priority
URL: https://github.com/apache/flink/pull/6839#discussion_r225103089
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java
 ##########
 @@ -156,6 +156,17 @@
 			"ports to avoid collisions when multiple Flink components are running on the same machine.
Per default " +
 			"Flink will pick a random port.");
 
+	/**
+	 * The thread priority for Flink's internal metric query service. The {@code 1} means the
min priority and the
+	 * {@code 10} means the max priority.
+	 */
+	public static final ConfigOption<Integer> QUERY_SERVICE_THREAD_PRIORITY =
+		key("metrics.internal.query-service.thread-priority")
+		.defaultValue(1)
+		.withDescription("The thread priority used for Flink's internal metric query service. The
thread is created" +
+			" by Akka's thread pool executor. " +
+			"The range of the priority is from 1 (MIN_PRIORITY) to 10 (MAX_PRIORITY).");
+
 
 Review comment:
   Add a remind that increase this might affect the main component would be nicer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Run MetricQueryService with lower priority
> ------------------------------------------
>
>                 Key: FLINK-10253
>                 URL: https://issues.apache.org/jira/browse/FLINK-10253
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Metrics
>    Affects Versions: 1.5.3, 1.6.0, 1.7.0
>            Reporter: Till Rohrmann
>            Assignee: vinoyang
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.7.0, 1.6.2, 1.5.5
>
>
> We should run the {{MetricQueryService}} with a lower priority than the main Flink components.
An idea would be to start the underlying threads with a lower priority.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message