flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10292) Generate JobGraph in StandaloneJobClusterEntrypoint only once
Date Tue, 02 Oct 2018 11:45:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635339#comment-16635339

ASF GitHub Bot commented on FLINK-10292:

zentol opened a new pull request #6786: [FLINK-10292][rest] Separate REST and Dispatcher RPC
thread pools
URL: https://github.com/apache/flink/pull/6786
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help
us improve Flink. To help the community review your contribution in the best possible way,
please go through the checklist below, which will get the contribution into a shape in which
it can be best reviewed.*
   *Please understand that we do not do this to make contributions to Flink a hassle. In order
to uphold a high standard of quality for code contributions, while at the same time managing
a large number of contributions, we need contributors to prepare the contributions well, and
give reviewers enough contextual information for the review. Please also understand that contributions
that do not follow this guide will take longer to review and thus typically be picked up with
lower priority by the community.*
   ## Contribution Checklist
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues).
Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request",
where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you
are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern:
`[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc
for PuncuatedWatermarkGenerator`.
     - Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
You can set up Travis CI to do that following [this guide](http://flink.apache.org/contribute-code.html#best-practices).
     - Each pull request should address only one issue, not mix up code from multiple issues.
     - Each commit in the pull request has a meaningful commit message (including the JIRA
     - Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
   **(The sections below can be removed for hotfixes of typos)**
   ## What is the purpose of the change
   This PR separates the REST and DispatcherRPC thread pools. Basically the `WebMonitorEndpoint`
creates it's own `ExecutorService` based on the `rest.server.numThreads` option, instead of
being passed the Dispatcher RPC's `Executor`.
   ## Brief change log
   * add `RestOptions#SERVER_NUM_THREADS`
   *  extend `RestServerEndpointConfiguration` to process new option (this change is questionable
since the `RestServerEndpoint` never uses this option)
   * create `ExecutorService` in `WebMonitorEndpoint`.
   ## Verifying this change
   I've added a basic test to cover the behavior of the `RestServerEndpointConfiguration`.
   Testing the executor service itself is possible (submit N blocking tasks, count how many
end up blocking, assert numBlocking==configuredNumThreads) but getting it stable is tricky.
   ## Documentation
     - Does this pull request introduce a new feature? (yes )
     - If yes, how is the feature documented? (docs)

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Generate JobGraph in StandaloneJobClusterEntrypoint only once
> -------------------------------------------------------------
>                 Key: FLINK-10292
>                 URL: https://issues.apache.org/jira/browse/FLINK-10292
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.6.0, 1.7.0
>            Reporter: Till Rohrmann
>            Assignee: vinoyang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0, 1.6.2
> Currently the {{StandaloneJobClusterEntrypoint}} generates the {{JobGraph}} from the
given user code every time it starts/is restarted. This can be problematic if the the {{JobGraph}}
generation has side effects. Therefore, it would be better to generate the {{JobGraph}} only
once and store it in HA storage instead from where to retrieve.

This message was sent by Atlassian JIRA

View raw message