flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10295) Tokenisation of Program Args resulting in unexpected results
Date Mon, 01 Oct 2018 10:09:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633806#comment-16633806
] 

ASF GitHub Bot commented on FLINK-10295:
----------------------------------------

zentol commented on a change in pull request #6754: [FLINK-10295] Add support of passing jar
arguments as list of separate strings in REST API
URL: https://github.com/apache/flink/pull/6754#discussion_r221549739
 
 

 ##########
 File path: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunMessageParameters.java
 ##########
 @@ -29,32 +28,18 @@
 /**
  * {@link MessageParameters} for {@link JarRunHandler}.
  */
-public class JarRunMessageParameters extends MessageParameters {
+public class JarRunMessageParameters extends JarMessageParameters {
 
-	public final JarIdPathParameter jarIdPathParameter = new JarIdPathParameter();
+	final AllowNonRestoredStateQueryParameter allowNonRestoredStateQueryParameter = new AllowNonRestoredStateQueryParameter();
 
-	public final ProgramArgsQueryParameter programArgsQueryParameter = new ProgramArgsQueryParameter();
-
-	public final EntryClassQueryParameter entryClassQueryParameter = new EntryClassQueryParameter();
-
-	public final ParallelismQueryParameter parallelismQueryParameter = new ParallelismQueryParameter();
-
-	public final AllowNonRestoredStateQueryParameter allowNonRestoredStateQueryParameter = new
AllowNonRestoredStateQueryParameter();
-
-	public final SavepointPathQueryParameter savepointPathQueryParameter = new SavepointPathQueryParameter();
-
-	@Override
-	public Collection<MessagePathParameter<?>> getPathParameters() {
-		return Collections.singletonList(jarIdPathParameter);
-	}
+	final SavepointPathQueryParameter savepointPathQueryParameter = new SavepointPathQueryParameter();
 
 	@Override
 	public Collection<MessageQueryParameter<?>> getQueryParameters() {
-		return Collections.unmodifiableCollection(Arrays.asList(
-			programArgsQueryParameter,
-			entryClassQueryParameter,
-			parallelismQueryParameter,
+		Collection<MessageQueryParameter<?>> pars = super.getQueryParameters();
+		pars.addAll(Arrays.asList(
 
 Review comment:
   Since you're creating a new list anyway and the total size is known, add the super parameter
to that one instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Tokenisation of Program Args resulting in unexpected results
> ------------------------------------------------------------
>
>                 Key: FLINK-10295
>                 URL: https://issues.apache.org/jira/browse/FLINK-10295
>             Project: Flink
>          Issue Type: Bug
>          Components: REST, Webfrontend
>    Affects Versions: 1.5.0, 1.6.0, 1.7.0
>            Reporter: Gaurav Singhania
>            Assignee: Andrey Zagrebin
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>         Attachments: sample_request.txt
>
>
> We were upgrading from Flink 1.4 to 1.6. At present we have a jar which takes all the
details to run the job as program args against a jarid, including sql query and kafka details.
In version 1.5 the program args are tokenised as a result single quote (') and double quote(")
are stripped from the arguments. This results in malformed args.
> Attached a sample request for reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message