flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10398) Add Tanh math function supported in Table API and SQL
Date Mon, 15 Oct 2018 09:13:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649942#comment-16649942

ASF GitHub Bot commented on FLINK-10398:

yanghua commented on a change in pull request #6736: [FLINK-10398][table] Add Tanh math function
supported in Table API and SQL
URL: https://github.com/apache/flink/pull/6736#discussion_r225090888

 File path: docs/dev/table/functions.md
 @@ -1219,6 +1219,18 @@ TAN(numeric)
+    <tr>
+      <td>
+        {% highlight text %}
+{% endhighlight %}
+      </td>
+      <td>
+        <p>Returns the hyperbolic tangent of <i>NUMERIC</i>.</p>

+        <p>Return value type is <i>DOUBLE</i>.</p>
 Review comment:
   @pnowojski Yes, in cosh PR, @xccui  has given this review suggestion. But because I submitted
a lot of PRs, I forgot this suggestion, and you probably didn't pay attention to it (this
is why I disscuss with xccui that if we review more efficiently and it would be easier to
avoid this happening). In the end, I used that PR as a template.
   I think this question has been 100% clear. Respect your and @xccui 's review suggestions.
Thank you again for your time and effort.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Add Tanh math function supported in Table API and SQL
> -----------------------------------------------------
>                 Key: FLINK-10398
>                 URL: https://issues.apache.org/jira/browse/FLINK-10398
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>            Reporter: vinoyang
>            Assignee: vinoyang
>            Priority: Minor
>              Labels: pull-request-available
> refer to : https://www.techonthenet.com/oracle/functions/tanh.php

This message was sent by Atlassian JIRA

View raw message