flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10405) Port JobManagerFailsITCase to new code base
Date Mon, 15 Oct 2018 15:08:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650342#comment-16650342
] 

ASF GitHub Bot commented on FLINK-10405:
----------------------------------------

TisonKun commented on a change in pull request #6841: [FLINK-10405] [tests] Port JobManagerFailsITCase
to new code base
URL: https://github.com/apache/flink/pull/6841#discussion_r225202176
 
 

 ##########
 File path: flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureRecoveryITCase.java
 ##########
 @@ -325,6 +325,21 @@ public void run() {
 			dispatcherProcesses[1] = new DispatcherProcess(1, config);
 			dispatcherProcesses[1].startProcess();
 
+			// get new dispatcher gateway
+			leaderListener.waitForNewLeader(deadline.timeLeft().toMillis());
+
+			leaderAddress = leaderListener.getAddress();
+			leaderId = leaderListener.getLeaderSessionID();
+
+			final CompletableFuture<DispatcherGateway> newDispatcherGatewayFuture = rpcService.connect(
+				leaderAddress,
+				DispatcherId.fromUuid(leaderId),
+				DispatcherGateway.class);
+			final DispatcherGateway newDispatcherGateway = newDispatcherGatewayFuture.get();
+
+			// Wait for all task managers to connect to the new leading job manager
+			waitForTaskManagers(numberOfTaskManagers, newDispatcherGateway, deadline.timeLeft());
 
 Review comment:
   @tillrohrmann So I revert this change to proceed this pull request?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Port JobManagerFailsITCase to new code base
> -------------------------------------------
>
>                 Key: FLINK-10405
>                 URL: https://issues.apache.org/jira/browse/FLINK-10405
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>    Affects Versions: 1.7.0
>            Reporter: TisonKun
>            Assignee: TisonKun
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> Port {{JobManagerFailsITCase}} to new code base.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message