flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10423) Forward RocksDB native metrics to Flink metrics reporter
Date Mon, 15 Oct 2018 10:41:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650050#comment-16650050
] 

ASF GitHub Bot commented on FLINK-10423:
----------------------------------------

zentol commented on a change in pull request #6814: [FLINK-10423][rocksdb][metrics] rocksdb
native metrics monitor
URL: https://github.com/apache/flink/pull/6814#discussion_r225112700
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/memory/MemoryStateBackend.java
 ##########
 @@ -302,14 +303,15 @@ public OperatorStateBackend createOperatorStateBackend(
 
 	@Override
 	public <K> AbstractKeyedStateBackend<K> createKeyedStateBackend(
-			Environment env,
-			JobID jobID,
-			String operatorIdentifier,
-			TypeSerializer<K> keySerializer,
-			int numberOfKeyGroups,
-			KeyGroupRange keyGroupRange,
-			TaskKvStateRegistry kvStateRegistry,
-			TtlTimeProvider ttlTimeProvider) {
+		Environment env,
 
 Review comment:
   please revert the indentation change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Forward RocksDB native metrics to Flink metrics reporter 
> ---------------------------------------------------------
>
>                 Key: FLINK-10423
>                 URL: https://issues.apache.org/jira/browse/FLINK-10423
>             Project: Flink
>          Issue Type: New Feature
>          Components: Metrics, State Backends, Checkpointing
>            Reporter: Seth Wiesman
>            Assignee: Seth Wiesman
>            Priority: Major
>              Labels: pull-request-available
>
> RocksDB contains a number of metrics at the column family level about current memory
usage, open memtables,  etc that would be useful to users wishing greater insight what rocksdb
is doing. This work is inspired heavily by the comments on this rocksdb issue thread (https://github.com/facebook/rocksdb/issues/3216#issuecomment-348779233)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message