flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10431) Extract scheduling-related code from SlotPool
Date Wed, 24 Oct 2018 17:03:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662543#comment-16662543

ASF GitHub Bot commented on FLINK-10431:

tillrohrmann commented on a change in pull request #6898: [FLINK-10431] Extraction of scheduling-related
code from SlotPool into preliminary Scheduler
URL: https://github.com/apache/flink/pull/6898#discussion_r227871624

 File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
 @@ -136,12 +143,13 @@
 	private String jobManagerAddress;
+	private MainThreadExecutable jmMainThreadScheduledExecutor;
 	// ------------------------------------------------------------------------
-	protected SlotPool(RpcService rpcService, JobID jobId, SchedulingStrategy schedulingStrategy)
+	protected SlotPool(JobID jobId, SchedulingStrategy schedulingStrategy) {
 Review comment:
   This class still contains a lot of code which actually moved to the new `Scheduler`. Can
we remove this code? Having this code still in this class makes it extremely hard to review.
Of course, this would mean that we also need to adapt the `SlotPoolTests` which makes sense

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Extract scheduling-related code from SlotPool
> ---------------------------------------------
>                 Key: FLINK-10431
>                 URL: https://issues.apache.org/jira/browse/FLINK-10431
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.7.0
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Major
>              Labels: pull-request-available
> The other half of the current scheduling logic is the management of slot sharing and
is located in the SlotPool. We need to extract this logic into our new Scheduler component
from the previous step. This leaves us with a simpler SlotPool that mainly cares about obtaining,
holding, and releasing slots in interaction with a ResourceManager. The new Scheduler can
now identify slot sharing groups and interacts with the SlotPool.

This message was sent by Atlassian JIRA

View raw message