flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10431) Extract scheduling-related code from SlotPool
Date Wed, 24 Oct 2018 17:03:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662546#comment-16662546

ASF GitHub Bot commented on FLINK-10431:

tillrohrmann commented on a change in pull request #6898: [FLINK-10431] Extraction of scheduling-related
code from SlotPool into preliminary Scheduler
URL: https://github.com/apache/flink/pull/6898#discussion_r227877459

 File path: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcEndpoint.java
 @@ -312,7 +313,7 @@ public void validateRunsInMainThread() {
 	 * Executor which executes runnables in the main thread context.
-	protected static class MainThreadExecutor implements Executor {
+	protected static class MainThreadExecutor implements MainThreadExecutable {
 Review comment:
   `MainThreadExecutable` was actually intended to be a marker interface for the `RpcServer`.
I would recommend to let the `MainThreadExecutor` implement the `ScheduledExecutor`. That
way, there is no need to change the `MainThreadExecutable`.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Extract scheduling-related code from SlotPool
> ---------------------------------------------
>                 Key: FLINK-10431
>                 URL: https://issues.apache.org/jira/browse/FLINK-10431
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.7.0
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Major
>              Labels: pull-request-available
> The other half of the current scheduling logic is the management of slot sharing and
is located in the SlotPool. We need to extract this logic into our new Scheduler component
from the previous step. This leaves us with a simpler SlotPool that mainly cares about obtaining,
holding, and releasing slots in interaction with a ResourceManager. The new Scheduler can
now identify slot sharing groups and interacts with the SlotPool.

This message was sent by Atlassian JIRA

View raw message