flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10490) OperatorSnapshotUtil should probably use SavepointV2Serializer
Date Wed, 24 Oct 2018 15:35:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662427#comment-16662427
] 

ASF GitHub Bot commented on FLINK-10490:
----------------------------------------

zentol commented on issue #6910: [FLINK-10490][tests] OperatorSnapshotUtil should use SavepointV2Seria…
URL: https://github.com/apache/flink/pull/6910#issuecomment-432708555
 
 
   The code loading the savepoint is aware of previous versions and starts a migration routine
if a v1 savepoint is detected; the savepoint is loaded using the v1 serializer and migrated
before it is passed to the task.
   I supposed our migration tests aren't affected since they don't make structural changes
to jobs, which IIRC is the major limitation of the old format.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> OperatorSnapshotUtil should probably use SavepointV2Serializer
> --------------------------------------------------------------
>
>                 Key: FLINK-10490
>                 URL: https://issues.apache.org/jira/browse/FLINK-10490
>             Project: Flink
>          Issue Type: Test
>          Components: Tests
>    Affects Versions: 1.7.0
>            Reporter: Stefan Richter
>            Priority: Major
>              Labels: pull-request-available
>
> {{OperatorSnapshotUtil}} is used for testing savepoint migration. This utility internally
still uses {{SavepointV1Serializer}} and I would assume that it should use {{SavepointV2Serializer}}.
I wonder if that means that some newer cases are actually not covered in the migration tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message