flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10511) Code duplication of creating RPC service in ClusterEntrypoint and AkkaRpcServiceUtils
Date Mon, 15 Oct 2018 09:42:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649976#comment-16649976
] 

ASF GitHub Bot commented on FLINK-10511:
----------------------------------------

Clarkkkkk opened a new pull request #6845: [FLINK-10511][Cluster Management] Reuse the port
selection and RPC se…
URL: https://github.com/apache/flink/pull/6845
 
 
   ## What is the purpose of the change
   
   Reuse the port selection and RPC service creation logic in JM and TM
   
   ## Brief change log
     - Add support for creating RPC service for a port range in AkkaRpcServiceUtils
     - Get rid of port selection of TaskManager and use AkkaRpcServiceUtils instead
     - Move the creation of RpcService to AkkaRpcServiceUtils in ClusterEntrypoint
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as TaskManagerRunnerTest and all
kinds of integration tests.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Code duplication of creating RPC service in ClusterEntrypoint and AkkaRpcServiceUtils
> -------------------------------------------------------------------------------------
>
>                 Key: FLINK-10511
>                 URL: https://issues.apache.org/jira/browse/FLINK-10511
>             Project: Flink
>          Issue Type: Improvement
>          Components: Cluster Management
>            Reporter: Shimin Yang
>            Assignee: Shimin Yang
>            Priority: Minor
>              Labels: pull-request-available
>
> The TaskManagerRunner is using AkkaRpcServiceUtils to create RPC service, but the ClusterEntrypoint
use a protected method to do the same job. I think it's better to use the same method in AkkaRpcServiceUtils for
reuse of code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message