flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Rohrmann (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (FLINK-10527) Cleanup constant isNewMode in YarnTestBase
Date Sun, 21 Oct 2018 20:00:00 GMT

     [ https://issues.apache.org/jira/browse/FLINK-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Till Rohrmann resolved FLINK-10527.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.7.0

Fixed via https://github.com/apache/flink/commit/7b040b915504e59243c642b1f4a84c956d96d134

> Cleanup constant isNewMode in YarnTestBase
> ------------------------------------------
>
>                 Key: FLINK-10527
>                 URL: https://issues.apache.org/jira/browse/FLINK-10527
>             Project: Flink
>          Issue Type: Sub-task
>          Components: YARN
>            Reporter: vinoyang
>            Assignee: vinoyang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> This seems to be a residual problem with FLINK-10396. It is set to true in that PR. Currently
it has three usage scenarios:
> 1. assert, caused an error
> {code:java}
> assumeTrue("The new mode does not start TMs upfront.", !isNewMode);
> {code}
> 2. if (!isNewMode) the logic in the block would not have invoked, the if block can be
removed
> 3. if (isNewMode) always been invoked, the if statement can be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message