flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10545) Remove JobManagerLeaderSessionIDITCase
Date Mon, 15 Oct 2018 08:55:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649907#comment-16649907
] 

ASF GitHub Bot commented on FLINK-10545:
----------------------------------------

tillrohrmann commented on issue #6840: [FLINK-10545] [tests] Remove JobManagerLeaderSessionIDITCase
URL: https://github.com/apache/flink/pull/6840#issuecomment-429761872
 
 
   Thanks for your contribution @TisonKun. The fencing is covered by `FencedRpcEndpointTest`.
Merging this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove JobManagerLeaderSessionIDITCase
> --------------------------------------
>
>                 Key: FLINK-10545
>                 URL: https://issues.apache.org/jira/browse/FLINK-10545
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>    Affects Versions: 1.7.0
>            Reporter: TisonKun
>            Assignee: TisonKun
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> {{JobManagerLeaderSessionIDITCase.scala}} is based on legacy mode and I think we now
have {{FencingToken}} and need not to maintain or port this test. Just simply remove it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message