flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Piotr Nowojski (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (FLINK-10606) Construct NetworkEnvironment simple for tests
Date Tue, 23 Oct 2018 14:01:00 GMT

     [ https://issues.apache.org/jira/browse/FLINK-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Piotr Nowojski closed FLINK-10606.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.7.0
                   1.6.3
                   1.5.6

Merged to:
* master as: ee6a4dead18348f72166f980b01868d896e1f88f
* release-1.6 as 57b990925b0944be224aff82cf3400035ec44d1d
* release-1.5 as 5f0504027f2703b65a5d10e92ede858ec7cd3cc9

> Construct NetworkEnvironment simple for tests
> ---------------------------------------------
>
>                 Key: FLINK-10606
>                 URL: https://issues.apache.org/jira/browse/FLINK-10606
>             Project: Flink
>          Issue Type: Test
>          Components: Network, Tests
>    Affects Versions: 1.6.1, 1.7.0
>            Reporter: zhijiang
>            Assignee: zhijiang
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.5.6, 1.6.3, 1.7.0
>
>
> Currently, five tests would create {{NetworkEnvironment}} in different places and the
most of parameters are common in constructing it.
> We can provide a simple way for constructing the {{NetworkEnvironment}} with less parameters
to deduplicate the common codes, which can bring benefits for future new tests.
> We can define a static nested {{NetworkEnvironmentBuilder}} inside the {{NetworkEnvironment
or a simple constructor directly as the option.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message