flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10663) Closing StreamingFileSink can cause NPE
Date Wed, 24 Oct 2018 11:11:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662130#comment-16662130
] 

ASF GitHub Bot commented on FLINK-10663:
----------------------------------------

GJL opened a new pull request #6915: [FLINK-10663][streaming] Fix NPE when StreamingFileSink
is closed without initialization.
URL: https://github.com/apache/flink/pull/6915
 
 
   
   ## What is the purpose of the change
   
   *There is a potential NPE in the StreamingFileSink. If you don't want the NPE, this PR
should be merged.*
   
   cc: @kl0u 
   
   ## Brief change log
   
     - *Add null check to `StreamingFileSink#close()`.*
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *Added unit test to `LocalStreamingFileSinkTest`.* 
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes**
/ no)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not
documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Closing StreamingFileSink can cause NPE
> ---------------------------------------
>
>                 Key: FLINK-10663
>                 URL: https://issues.apache.org/jira/browse/FLINK-10663
>             Project: Flink
>          Issue Type: Bug
>          Components: filesystem-connector, Streaming Connectors
>    Affects Versions: 1.6.1, 1.7.0
>         Environment: Rev cb141940821bcf62f4102dfd5c76aff99d0c15d1
>            Reporter: Gary Yao
>            Assignee: Gary Yao
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.6.3, 1.7.0
>
>
> *Description*
> If the sink is closed before it's state is initialized, an NPE is thrown.
> *Stacktrace*
> {code}
> java.lang.NullPointerException
> 	at org.apache.flink.streaming.api.functions.sink.filesystem.StreamingFileSink.close(StreamingFileSink.java:378)
> 	at org.apache.flink.api.common.functions.util.FunctionUtils.closeFunction(FunctionUtils.java:43)
> 	at org.apache.flink.streaming.api.operators.AbstractUdfStreamOperator.dispose(AbstractUdfStreamOperator.java:117)
> 	at org.apache.flink.streaming.runtime.tasks.StreamTask.disposeAllOperators(StreamTask.java:477)
> 	at org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:378)
> 	at org.apache.flink.runtime.taskmanager.Task.run(Task.java:704)
> 	at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message