flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Rohrmann (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10678) Add a switch to run_test to configure if logs should be checked for errors/excepions
Date Tue, 30 Oct 2018 15:16:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668854#comment-16668854
] 

Till Rohrmann commented on FLINK-10678:
---------------------------------------

I guess that every test which disables the log verification should have a different set of
assertions in place to cover what is considered being a success or a failure. Moreover, we
should always keep a set of end-to-end tests where we are sure that no exceptions should be
thrown (in the happy case) and, thus, can activate the log verification.

> Add a switch to run_test to configure if logs should be checked for errors/excepions
> ------------------------------------------------------------------------------------
>
>                 Key: FLINK-10678
>                 URL: https://issues.apache.org/jira/browse/FLINK-10678
>             Project: Flink
>          Issue Type: Bug
>          Components: E2E Tests
>    Affects Versions: 1.7.0
>            Reporter: Dawid Wysakowicz
>            Assignee: Dawid Wysakowicz
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> After adding the switch, we should disable log checking for nightly-tests that currently
fail (or fix the test).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message