flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10600) Provide End-to-end test cases for modern Kafka connectors
Date Mon, 05 Nov 2018 14:21:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675219#comment-16675219

ASF GitHub Bot commented on FLINK-10600:

pnowojski commented on a change in pull request #6924: [FLINK-10600] Provide End-to-end test
cases for modern Kafka connectors
URL: https://github.com/apache/flink/pull/6924#discussion_r230764838

 File path: flink-examples/flink-examples-streaming-kafka-0.10/pom.xml
 @@ -0,0 +1,76 @@
+<?xml version="1.0" encoding="UTF-8"?>
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+  http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+		 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+		 xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+	<parent>
+		<artifactId>flink-examples</artifactId>
+		<groupId>org.apache.flink</groupId>
+		<version>1.7-SNAPSHOT</version>
+	</parent>
+	<modelVersion>4.0.0</modelVersion>
+	<artifactId>flink-examples-streaming-kafka-0.10</artifactId>
+	<dependencies>
+		<dependency>
 Review comment:
   It will be better if you do not relay on transitive dependencies here and explicitly list
`flink-streaming-java` and `flink-java` dependencies in the pom. Now it works because those
modules are transitive dependency of `flink-connector-kafka-0.10` while `Kafka010Example`
explicitly uses/depends on them.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Provide End-to-end test cases for modern Kafka connectors
> ---------------------------------------------------------
>                 Key: FLINK-10600
>                 URL: https://issues.apache.org/jira/browse/FLINK-10600
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Kafka Connector
>            Reporter: vinoyang
>            Assignee: vinoyang
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.7.0

This message was sent by Atlassian JIRA

View raw message