flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10638) Invalid table scan resolution for temporal join queries
Date Thu, 01 Nov 2018 13:27:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671611#comment-16671611
] 

ASF GitHub Bot commented on FLINK-10638:
----------------------------------------

twalthr commented on a change in pull request #6981: [FLINK-10638][table] Invalid table scan
resolution for temporal join queries
URL: https://github.com/apache/flink/pull/6981#discussion_r230038751
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/FlinkRuleSets.scala
 ##########
 @@ -39,18 +39,14 @@ object FlinkRuleSets {
     SubQueryRemoveRule.JOIN)
 
   /**
-    * Handles proper conversion of correlate queries with temporal table functions
-    * into temporal table joins. This can create new table scans in the plan.
+    * Expand plan by replacing references to tables into a proper plan sub trees. Those rules
+    * can create new plan nodes.
     */
-  val TEMPORAL_JOIN_RULES: RuleSet = RuleSets.ofList(
-    LogicalCorrelateToTemporalTableJoinRule.INSTANCE
-  )
+  val EXPAND_PLAN_RULES: RuleSet = RuleSets.ofList(
 
 Review comment:
   We should make the rules in expand and post expand phase configurable through `org.apache.flink.table.calcite.CalciteConfigBuilder`
we also forgot this for the temporal join phase. We might have users that don't want to use
temporal joins and modify the rule sets accordingly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Invalid table scan resolution for temporal join queries
> -------------------------------------------------------
>
>                 Key: FLINK-10638
>                 URL: https://issues.apache.org/jira/browse/FLINK-10638
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Assignee: Piotr Nowojski
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> Registered tables that contain a temporal join are not properly resolved when performing
a table scan.
> A planning error occurs when registering a table with a temporal join and reading from
it again.
> {code}
> LogicalProject(amount=[*($0, $4)])
>   LogicalFilter(condition=[=($3, $1)])
>     LogicalCorrelate(correlation=[$cor0], joinType=[inner], requiredColumns=[{2}])
>       LogicalTableScan(table=[[_DataStreamTable_0]])
>       LogicalTableFunctionScan(invocation=[Rates(CAST($cor0.rowtime):TIMESTAMP(3) NOT
NULL)], rowType=[RecordType(VARCHAR(65536) currency, BIGINT rate, TIME ATTRIBUTE(ROWTIME)
rowtime)], elementType=[class [Ljava.lang.Object;])
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message