flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Piotr Nowojski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10662) Refactor the ChannelSelector interface for single selected channel
Date Fri, 09 Nov 2018 13:56:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681454#comment-16681454
] 

Piotr Nowojski commented on FLINK-10662:
----------------------------------------

Yes, back in the past I was also thinking about this issue. I think defining a constant {{public
static final int ChannelSelector::ALL_CHANNELS = -1;}} would be ok. Alternatively {{BroadcastPartitioner#selectChannel()}}
could throw {{UnsupportedOperationException}}, but probably the {{-1}} is more clean of the
two.

[~NicoK] what do you think?

> Refactor the ChannelSelector interface for single selected channel
> ------------------------------------------------------------------
>
>                 Key: FLINK-10662
>                 URL: https://issues.apache.org/jira/browse/FLINK-10662
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>    Affects Versions: 1.5.4, 1.6.1
>            Reporter: zhijiang
>            Assignee: zhijiang
>            Priority: Minor
>
> In the discussion of broadcast improvement, [~pnowojski] pointed out the issue of improving
the current channel selector.
>  
> In {{ChannelSelector#selectChannels}}, it would return an array for selected channels.
But considering specific implementations, only {{BroadcastPartitioner}} would select all the
channels, and other implementations will select one channel. So we can simple this interface
to return single channel index for benefiting performance, and specialize the {{BroadcastPartitioner}}
in a more efficient way.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message