flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nico Kruber (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10662) Refactor the ChannelSelector interface for single selected channel
Date Mon, 19 Nov 2018 10:15:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691515#comment-16691515

Nico Kruber commented on FLINK-10662:

[~pnowojski] thanks for the clarification.

So this change for the {{RecordWriter}} makes sure that {{BroadcastPartitioner#selectChannels()}}
is never called for a broadcasting pattern, I'd prefer an {{UnsupportedOperationException}},
also to prevent undesired use.
If we allow this call for broadcasting as well, I'd also be fine with {{ChannelSelector::ALL_CHANNELS
= -1;}}.

> Refactor the ChannelSelector interface for single selected channel
> ------------------------------------------------------------------
>                 Key: FLINK-10662
>                 URL: https://issues.apache.org/jira/browse/FLINK-10662
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>    Affects Versions: 1.5.4, 1.6.1
>            Reporter: zhijiang
>            Assignee: zhijiang
>            Priority: Minor
> In the discussion of broadcast improvement, [~pnowojski] pointed out the issue of improving
the current channel selector.
> In {{ChannelSelector#selectChannels}}, it would return an array for selected channels.
But considering specific implementations, only {{BroadcastPartitioner}} would select all the
channels, and other implementations will select one channel. So we can simple this interface
to return single channel index for benefiting performance, and specialize the {{BroadcastPartitioner}}
in a more efficient way.

This message was sent by Atlassian JIRA

View raw message