flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chesnay Schepler (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (FLINK-10733) Misleading clean_log_files() in common.sh
Date Fri, 09 Nov 2018 07:12:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680972#comment-16680972
] 

Chesnay Schepler edited comment on FLINK-10733 at 11/9/18 7:11 AM:
-------------------------------------------------------------------

As of right now no test is calling this method, I'd rather just inline this method into the
{{test-runner-common}} so it's no longer accessible to tests.


was (Author: zentol):
As of right now no test is calling this method, I'd rather just inline this method into the
`test-runner-common` so it's no longer accessible to tests.

> Misleading clean_log_files() in common.sh
> -----------------------------------------
>
>                 Key: FLINK-10733
>                 URL: https://issues.apache.org/jira/browse/FLINK-10733
>             Project: Flink
>          Issue Type: Bug
>          Components: E2E Tests
>    Affects Versions: 1.6.2
>            Reporter: Kostas Kloudas
>            Assignee: vinoyang
>            Priority: Major
>              Labels: pull-request-available
>
> In the `common.sh` base script of the end-to-end tests, there is a `clean_stdout_files`
which cleans only the `*.out` files and a `clean_log_files` which cleans *both* `*.log` and
`*.out` files.
> Given the current behavior that at the end of a test, the logs are checked and if there
are exceptions (even expected ones but not whitelisted), the tests fails, some tests chose
to call the `clean_log_files` so that exceptions are ignored. In this case, also `*.out` files
are cleaned so if a test was checking for errors in the `.out` files, then the test will falsely
pass.
> The solution is as simple as renaming the method to something more descriptive like `clean_logs_and_output_files`,
but doing so, also includes checking if any existing tests were falsely passing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message