flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10800) Abstract the StreamPartitionerTest for common codes
Date Tue, 06 Nov 2018 09:37:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676428#comment-16676428
] 

ASF GitHub Bot commented on FLINK-10800:
----------------------------------------

zhijiangW commented on a change in pull request #7031: [FLINK-10800][network][test] Abstract
StreamPartitionerTest for common codes
URL: https://github.com/apache/flink/pull/7031#discussion_r231052709
 
 

 ##########
 File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/partitioner/StreamPartitionerTest.java
 ##########
 @@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.runtime.partitioner;
+
+import org.apache.flink.api.java.tuple.Tuple;
+import org.apache.flink.runtime.plugable.SerializationDelegate;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+import org.apache.flink.util.TestLogger;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Tests for different {@link StreamPartitioner} implementations.
+ */
+public class StreamPartitionerTest extends TestLogger {
+
+	protected StreamPartitioner<Tuple> streamPartitioner;
+	protected StreamRecord<Tuple> streamRecord = new StreamRecord<>(null);
+	protected SerializationDelegate<StreamRecord<Tuple>> sd = new SerializationDelegate<>(null);
+
+	@Test
+	public void testSelectChannelsLength() {
+		sd.setInstance(streamRecord);
 
 Review comment:
   👍

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Abstract the StreamPartitionerTest for common codes
> ---------------------------------------------------
>
>                 Key: FLINK-10800
>                 URL: https://issues.apache.org/jira/browse/FLINK-10800
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network, Tests
>    Affects Versions: 1.8.0
>            Reporter: zhijiang
>            Assignee: zhijiang
>            Priority: Minor
>              Labels: pull-request-available
>
> There are many duplicated codes in current {{ForwardPartitionerTest}}, {{RescalePartitionerTest}},
{{RebalancePartitionerTest}}, {{RebalancePartitionerTest}}, etc.
> The {{StreamPartitionerTest}} is defined for abstracting the common codes, this is the
preparation work for the FLINK-10790.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message