flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10800) Abstract the StreamPartitionerTest for common codes
Date Tue, 06 Nov 2018 10:19:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676505#comment-16676505
] 

ASF GitHub Bot commented on FLINK-10800:
----------------------------------------

zhijiangW commented on a change in pull request #7031: [FLINK-10800][network][test] Abstract
StreamPartitionerTest for common codes
URL: https://github.com/apache/flink/pull/7031#discussion_r231067080
 
 

 ##########
 File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/partitioner/ForwardPartitionerTest.java
 ##########
 @@ -29,31 +25,19 @@
 /**
  * Tests for {@link ForwardPartitioner}.
  */
-public class ForwardPartitionerTest {
-
-	private ForwardPartitioner<Tuple> forwardPartitioner;
-	private StreamRecord<Tuple> streamRecord = new StreamRecord<Tuple>(null);
-	private SerializationDelegate<StreamRecord<Tuple>> sd = new SerializationDelegate<StreamRecord<Tuple>>(
-			null);
+public class ForwardPartitionerTest extends StreamPartitionerTest {
 
 	@Before
 	public void setPartitioner() {
-		forwardPartitioner = new ForwardPartitioner<Tuple>();
-	}
-
-	@Test
-	public void testSelectChannelsLength() {
-		sd.setInstance(streamRecord);
-		assertEquals(1, forwardPartitioner.selectChannels(sd, 1).length);
-		assertEquals(1, forwardPartitioner.selectChannels(sd, 2).length);
-		assertEquals(1, forwardPartitioner.selectChannels(sd, 1024).length);
+		streamPartitioner = new ForwardPartitioner<>();
 	}
 
 	@Test
 	public void testSelectChannelsInterval() {
 		sd.setInstance(streamRecord);
-		assertEquals(0, forwardPartitioner.selectChannels(sd, 1)[0]);
-		assertEquals(0, forwardPartitioner.selectChannels(sd, 2)[0]);
-		assertEquals(0, forwardPartitioner.selectChannels(sd, 1024)[0]);
+
+		assertEquals(0, streamPartitioner.selectChannels(sd, 1)[0]);
 
 Review comment:
   This define could not be reused directly by `ShufflePartitionerTest` and `RebalancePartitionerTest`.
And it will not reduce the code lines totally for reuse ones. So I think it is not very worth
doing. What do you think or you have other concerns of this define?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Abstract the StreamPartitionerTest for common codes
> ---------------------------------------------------
>
>                 Key: FLINK-10800
>                 URL: https://issues.apache.org/jira/browse/FLINK-10800
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network, Tests
>    Affects Versions: 1.8.0
>            Reporter: zhijiang
>            Assignee: zhijiang
>            Priority: Minor
>              Labels: pull-request-available
>
> There are many duplicated codes in current {{ForwardPartitionerTest}}, {{RescalePartitionerTest}},
{{RebalancePartitionerTest}}, {{RebalancePartitionerTest}}, etc.
> The {{StreamPartitionerTest}} is defined for abstracting the common codes, this is the
preparation work for the FLINK-10790.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message