flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Clarkkkkk commented on a change in pull request #7168: [FLINK-6756][DataStream API] Provide Rich AsyncFunction to Scala API …
Date Sat, 01 Dec 2018 04:12:30 GMT
Clarkkkkk commented on a change in pull request #7168: [FLINK-6756][DataStream API] Provide
Rich AsyncFunction to Scala API …
URL: https://github.com/apache/flink/pull/7168#discussion_r238051554
 
 

 ##########
 File path: flink-streaming-scala/src/test/scala/org/apache/flink/streaming/api/scala/AsyncDataStreamITCase.scala
 ##########
 @@ -135,3 +158,19 @@ class MyAsyncFunction extends AsyncFunction[Int, Int] {
     resultFuture.complete(Seq(input * 3))
   }
 }
+
+class MyRichAsyncFunction extends RichAsyncFunction[Int, String] {
+  override def asyncInvoke(input: Int, resultFuture: ResultFuture[String]): Unit = {
 
 Review comment:
   I was also thinking about that. But here I want to verify the runtime I got here is a RichAsyncFunctionRuntimeContext,
which is a private inner class of RichAsyncFunction. So I cannot use isInstanceOf to verify
it. Perhaps I could move the inner class out of RichAsyncFunction and made it accessible by
test, so I can verify the RuntimeContext.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message