flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] twalthr commented on a change in pull request #7177: [FLINK-7599] [table] Support for aggregates in MATCH_RECOGNIZE
Date Tue, 04 Dec 2018 16:02:01 GMT
twalthr commented on a change in pull request #7177: [FLINK-7599] [table] Support for aggregates
in MATCH_RECOGNIZE
URL: https://github.com/apache/flink/pull/7177#discussion_r238716344
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/MatchCodeGenerator.scala
 ##########
 @@ -582,22 +671,33 @@ class MatchCodeGenerator(
 
       val transformFuncName = s"transformRowForAgg_$variableUID"
       val inputTransform: String = generateAggInputExprEvaluation(
-        exprs,
+        matchAgg.inputExprs,
         transformFuncName)
 
       generateAggCalculation(aggFunc, transformFuncName, inputTransform)
     }
 
+    private case class LogicalMatchAggCall(
 
 Review comment:
   nit: move all classes to the bottom to logically separate them from methods.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message