flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] walterddr commented on a change in pull request #7263: [FLINK-11081] Support binding port range for REST server
Date Tue, 11 Dec 2018 17:25:39 GMT
walterddr commented on a change in pull request #7263: [FLINK-11081] Support binding port range
for REST server
URL: https://github.com/apache/flink/pull/7263#discussion_r240711528
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/rest/RestServerEndpointConfigurationTest.java
 ##########
 @@ -49,17 +77,154 @@ public void testBasicMapping() throws ConfigurationException {
 		Configuration originalConfig = new Configuration();
 		originalConfig.setString(RestOptions.ADDRESS, ADDRESS);
 		originalConfig.setString(RestOptions.BIND_ADDRESS, BIND_ADDRESS);
-		originalConfig.setInteger(RestOptions.PORT, PORT);
+		originalConfig.setString(RestOptions.BIND_PORT, BIND_PORT);
 		originalConfig.setInteger(RestOptions.SERVER_MAX_CONTENT_LENGTH, CONTENT_LENGTH);
 		originalConfig.setString(WebOptions.TMP_DIR, temporaryFolder.getRoot().getAbsolutePath());
 
 		final RestServerEndpointConfiguration result = RestServerEndpointConfiguration.fromConfiguration(originalConfig);
 		Assert.assertEquals(ADDRESS, result.getRestAddress());
 		Assert.assertEquals(BIND_ADDRESS, result.getRestBindAddress());
-		Assert.assertEquals(PORT, result.getRestBindPort());
+		Assert.assertEquals(BIND_PORT, result.getRestBindPort());
 		Assert.assertEquals(CONTENT_LENGTH, result.getMaxContentLength());
 		Assert.assertThat(
 			result.getUploadDir().toAbsolutePath().toString(),
 			containsString(temporaryFolder.getRoot().getAbsolutePath()));
 	}
+
 
 Review comment:
   Can we add a test that tests initial port assignment failure (fall back to next available
port)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message