flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] hequn8128 commented on a change in pull request #7235: [FLINK-10976] [table] Add support for aggregate to table API
Date Wed, 12 Dec 2018 04:19:15 GMT
hequn8128 commented on a change in pull request #7235: [FLINK-10976] [table] Add support for
aggregate to table API
URL: https://github.com/apache/flink/pull/7235#discussion_r240877569
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
 ##########
 @@ -999,6 +999,47 @@ class Table(
     new OverWindowedTable(this, overWindows.toArray)
   }
 
+  /**
+    * Performs a global aggregate operation with an aggregate function. Use this before a
selection
+    * to perform the selection operation. The output will be flattened if the output type
is a
+    * composite type.
+    *
+    * Example:
+    *
+    * {{{
+    *   val aggFunc: AggregateFunction[_, _] = new MyAggregateFunction
+    *   tableEnv.registerFunction("aggFunc", aggFunc);
+    *   table.aggregate("aggFunc(a, b) as (f0, f1, f2)").select('f0, 'f1)
+    * }}}
+    */
+  def aggregate(aggregateFunction: Expression): AggregatedTable = {
+    unwrap(aggregateFunction, tableEnv) match {
 
 Review comment:
   Line 1016:1021 is duplicated with line 1139:1144. How about change Line 1016:1021 to:
   `groupBy().aggregate(aggregateFunction)`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message