flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] yanghua edited a comment on issue #7263: [FLINK-11081] Support binding port range for REST server
Date Wed, 12 Dec 2018 04:45:41 GMT
yanghua edited a comment on issue #7263: [FLINK-11081] Support binding port range for REST
server
URL: https://github.com/apache/flink/pull/7263#issuecomment-446460550
 
 
   `ConfigOption.PORT` ? I can not find it. 
   I guess what you want to express is `RestOptions.PORT`. I think that it can't be deprecated
here. Initially its responsibilities are both the binding port of the server and the connection
port of the client. Now the server's binding port is represented by `BIND_PORT`, then it can
also be used to represent the client's connection port. In some places it may be used:
   
   ```java
   Private void createClientConfiguration(URI restAddress) {
       Configuration restClientConfig = new Configuration();
       restClientConfig.setString(JobManagerOptions.ADDRESS, restAddress.getHost());
       restClientConfig.setInteger(RestOptions.PORT, restAddress.getPort());
       this.restClusterClientConfig = new UnmodifiableConfiguration(restClientConfig);
   }
   ```
   
   There should be two pairs of configuration items `BIND_ADDRESS/BIND_PORT` and `ADDRESS/PORT`
here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message