flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] walterddr commented on a change in pull request #7263: [FLINK-11081] Support binding port range for REST server
Date Wed, 12 Dec 2018 07:03:16 GMT
walterddr commented on a change in pull request #7263: [FLINK-11081] Support binding port range
for REST server
URL: https://github.com/apache/flink/pull/7263#discussion_r240900279
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestServerEndpoint.java
 ##########
 @@ -181,14 +184,44 @@ protected void initChannel(SocketChannel ch) {
 				.channel(NioServerSocketChannel.class)
 				.childHandler(initializer);
 
-			log.debug("Binding rest endpoint to {}:{}.", restBindAddress, restBindPort);
-			final ChannelFuture channel;
-			if (restBindAddress == null) {
-				channel = bootstrap.bind(restBindPort);
-			} else {
-				channel = bootstrap.bind(restBindAddress, restBindPort);
+			ChannelFuture channel;
+
+			// parse port range definition and create port iterator
+			Iterator<Integer> portsIterator;
+			try {
+				portsIterator = NetUtils.getPortRangeFromString(restBindPort);
+			} catch (Exception e) {
 
 Review comment:
   What I meant is "should we catch `RuntimeExceptions`". function signature of `startActorSystem`
explicitly throws a generic `Exception` so there's no way to distinguish in `BootstrapTool`
use case. But here since we are directly using `NetUtil.getPor...`, we might be able to do
a better job. 
   
   Regarding whether we should catch it. I am fine with either decision as long as they are
properly documented.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message