flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] igalshilman commented on a change in pull request #7313: [FLINK-11116][fs-connector] Removed randomness from HDFS and Local fs writers.
Date Tue, 18 Dec 2018 11:24:53 GMT
igalshilman commented on a change in pull request #7313: [FLINK-11116][fs-connector] Removed
randomness from HDFS and Local fs writers.
URL: https://github.com/apache/flink/pull/7313#discussion_r242465150
 
 

 ##########
 File path: flink-core/src/test/java/org/apache/flink/core/fs/AbstractRecoverableWriterTest.java
 ##########
 @@ -103,6 +103,49 @@ public void testCloseWithNoData() throws Exception {
 		}
 	}
 
+	@Test
+	public void testOverwritingUponReopeningClosedUncommittedFiles() throws Exception {
 
 Review comment:
   The test is a bit unclear, can you try to refactor the test so it would have setup/action/assertion
structure?
   For example:
   ```
   writeCompletedFile(..)
   writeUncompletedFile(..)
   
   List<..> directoy = listDirectory(path)
   
   assert(directory, allOf( ..) );
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message