flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] dawidwys commented on a change in pull request #7258: [FLINK-11084]Throw a hard exception to remind developers while there's no stream node between two split transformation
Date Tue, 18 Dec 2018 13:29:37 GMT
dawidwys commented on a change in pull request #7258: [FLINK-11084]Throw a hard exception to
remind developers while there's no stream node between two split transformation
URL: https://github.com/apache/flink/pull/7258#discussion_r242535000
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java
 ##########
 @@ -643,4 +645,18 @@ private String determineSlotSharingGroup(String specifiedGroup, Collection<Integ
 			return inputGroup == null ? "default" : inputGroup;
 		}
 	}
+
+	private <T> void validateSplitTransformation(StreamTransformation<T> input)
{
+		if (input instanceof SelectTransformation || input instanceof SplitTransformation) {
 
 Review comment:
   What about `SideOutputTransformation`? Can we apply split on top of side-output?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message