flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] asicoe commented on a change in pull request #4725: [FLINK-7689] [Streaming Connectors] Added metrics to JDBCOutputFormat in order to be able to m…
Date Tue, 18 Dec 2018 14:01:59 GMT
asicoe commented on a change in pull request #4725: [FLINK-7689] [Streaming Connectors] Added
metrics to JDBCOutputFormat in order to be able to m…
URL: https://github.com/apache/flink/pull/4725#discussion_r242546922
 
 

 ##########
 File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
 ##########
 @@ -58,6 +68,11 @@
 
 	private int[] typesArray;
 
+	private Meter batchLimitReachedMeter;
+	private Meter flushMeter;
 
 Review comment:
   they need the runtime to be initialised though

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message