flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] dawidwys opened a new pull request #7328: [FLINK-11191][table] Check for ambiguous columns in MATCH_RECOGNIZE
Date Tue, 18 Dec 2018 14:39:42 GMT
dawidwys opened a new pull request #7328: [FLINK-11191][table] Check for ambiguous columns
in MATCH_RECOGNIZE
URL: https://github.com/apache/flink/pull/7328
 
 
   ## What is the purpose of the change
   
   Added a validation that checks if no ambiguous columns are defined in `MATCH_RECOGNIZE`
clause. Without the check there is a cryptic message thrown from code generation stack.
   
   ## Verifying this change
   
   - org.apache.flink.table.`match`.MatchRecognizeValidationTest#testValidatingAmbiguousColumns
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not
documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message