flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10977) Add FlatAggregate operator to unbounded streaming Table API
Date Wed, 12 Dec 2018 11:39:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718839#comment-16718839
] 

ASF GitHub Bot commented on FLINK-10977:
----------------------------------------

dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate
operator to streaming Table API
URL: https://github.com/apache/flink/pull/7209#discussion_r240939534
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
 ##########
 @@ -358,8 +358,12 @@ abstract class StreamTableEnvironment(
         tableKeys match {
           case Some(keys) => upsertSink.setKeyFields(keys)
           case None if isAppendOnlyTable => upsertSink.setKeyFields(null)
-          case None if !isAppendOnlyTable => throw new TableException(
-            "UpsertStreamTableSink requires that Table has full primary keys if it is updated.")
+          case None if !isAppendOnlyTable && upsertSink.enforceKeyFields() == null
=>
 
 Review comment:
   upsertSink.enforceKeyFields() == null || upsertSink.enforceKeyFields().length == 0

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add FlatAggregate operator to unbounded streaming Table API
> -----------------------------------------------------------
>
>                 Key: FLINK-10977
>                 URL: https://issues.apache.org/jira/browse/FLINK-10977
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>            Reporter: sunjincheng
>            Assignee: Hequn Cheng
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.8.0
>
>
> Add FlatAggregate operator to streaming Table API as described in [Google doc|https://docs.google.com/document/d/1tnpxg31EQz2-MEzSotwFzqatsB4rNLz0I-l_vPa5H4Q/edit#heading=h.q23rny2iglsr].
> The usage:
> {code:java}
> val res = tab
> .groupBy('a) // leave out groupBy-clause to define global table aggregates
> .flatAgg(fun: TableAggregateFunction) // output has columns 'a, 'b, 'c
> .select('a, 'c){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message