flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-11010) Flink SQL timestamp is inconsistent with currentProcessingTime()
Date Tue, 11 Dec 2018 06:20:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-11010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716320#comment-16716320
] 

ASF GitHub Bot commented on FLINK-11010:
----------------------------------------

lamber-ken commented on a change in pull request #7180: [FLINK-11010] [TABLE] Flink SQL timestamp
is inconsistent with currentProcessingTime()
URL: https://github.com/apache/flink/pull/7180#discussion_r240484482
 
 

 ##########
 File path: flink-libraries/flink-table/src/test/java/org/apache/flink/table/runtime/stream/sql/JavaSqlITCase.java
 ##########
 @@ -164,4 +167,35 @@ public void testUnion() throws Exception {
 
 		StreamITCase.compareWithList(expected);
 	}
+
+	@Test
+	public void testProctime() throws Exception {
+		StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
+		StreamTableEnvironment tableEnv = TableEnvironment.getTableEnvironment(env);
+
+		DataStream<Tuple3<Integer, Long, String>> ds = JavaStreamTestData.getSmall3TupleDataSet(env);
+		tableEnv.registerDataStream("MyTable", ds, "a, b, c, proctime.proctime");
+
+		String sqlQuery = "select proctime from MyTable";
+
+		Table result = tableEnv.sqlQuery(sqlQuery);
+
+		tableEnv
+			.toAppendStream(result, TypeInformation.of(Row.class))
+			.addSink(new SinkFunction<Row>() {
+				@Override
+				public void invoke(Row value, Context context) throws Exception {
+
+					Timestamp procTimestamp = (Timestamp) value.getField(0);
+
+					// validate the second here
+					long procSecondTime = procTimestamp.getTime() / 1000;
 
 Review comment:
   yeah, it's better to validate hour. I'll update.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Flink SQL timestamp is inconsistent with currentProcessingTime()
> ----------------------------------------------------------------
>
>                 Key: FLINK-11010
>                 URL: https://issues.apache.org/jira/browse/FLINK-11010
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API &amp; SQL
>    Affects Versions: 1.6.2, 1.7.0, 1.8.0, 1.7.1
>            Reporter: lamber-ken
>            Assignee: lamber-ken
>            Priority: Major
>              Labels: pull-request-available
>
> Flink SQL timestamp is inconsistent with currentProcessingTime().
>  
> the ProcessingTime is just implemented by invoking System.currentTimeMillis() but the
long value will be automatically wrapped to a Timestamp with the following statement: 
> `new java.sql.Timestamp(time - TimeZone.getDefault().getOffset(time));`



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message