flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-11045) UserCodeClassLoader has not been set correctly for RuntimeUDFContext in CollectionExecutor
Date Mon, 03 Dec 2018 23:49:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-11045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707991#comment-16707991
] 

ASF GitHub Bot commented on FLINK-11045:
----------------------------------------

sunjincheng121 commented on issue #7213: [FLINK-11045][table] Set correct UserCodeClassLoader
for RuntimeUDFContext in CollectionExecutor
URL: https://github.com/apache/flink/pull/7213#issuecomment-443914687
 
 
   Hi @hequn8128 Thanks for the good catch!
   The change looks good to me! 
   +1 to merged.
   Thanks,
   Jincheng

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> UserCodeClassLoader has not been set correctly for RuntimeUDFContext in CollectionExecutor
> ------------------------------------------------------------------------------------------
>
>                 Key: FLINK-11045
>                 URL: https://issues.apache.org/jira/browse/FLINK-11045
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API &amp; SQL
>            Reporter: Hequn Cheng
>            Assignee: Hequn Cheng
>            Priority: Major
>              Labels: pull-request-available
>
> We should use {{UserCodeClassLoader}} when new a {{RuntimeUDFContext}}.
> i.e., Change the code from
> {code:java}
> this.classLoader = getClass().getClassLoader();
> new RuntimeUDFContext(taskInfo, classLoader, executionConfig, cachedFiles, accumulators,
metrics)
> {code}
> to
> {code:java}
> new RuntimeUDFContext(taskInfo, Thread.currentThread().getContextClassLoader, executionConfig,
cachedFiles, accumulators, metrics)
> {code}
> in {{CollectionExecutor}}.
> FYI. This is a problem reported from the [user mailing list|http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Table-API-example-Table-program-cannot-be-compiled-This-is-a-bug-Please-file-an-issue-td24852.html].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message