flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-11048) Ability to programmatically execute streaming pipeline with savepoint restore
Date Thu, 06 Dec 2018 10:46:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711262#comment-16711262
] 

ASF GitHub Bot commented on FLINK-11048:
----------------------------------------

zentol commented on a change in pull request #7249: [FLINK-11048] Ability to programmatically
execute streaming pipeline with savepoint restore
URL: https://github.com/apache/flink/pull/7249#discussion_r239405800
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/RemoteStreamEnvironment.java
 ##########
 @@ -169,39 +170,46 @@ public RemoteStreamEnvironment(String host, int port, Configuration
clientConfig
 		}
 	}
 
-	@Override
-	public JobExecutionResult execute(String jobName) throws ProgramInvocationException {
-		StreamGraph streamGraph = getStreamGraph();
-		streamGraph.setJobName(jobName);
-		transformations.clear();
-		return executeRemotely(streamGraph, jarFiles);
+	protected List<URL> getJarFiles() throws ProgramInvocationException {
+		return jarFiles;
 	}
 
 	/**
 	 * Executes the remote job.
 	 *
-	 * @param streamGraph
-	 *            Stream Graph to execute
+	 * @param streamExecutionEnvironment
+	 *            Execution Environment with Stream Graph to execute
 	 * @param jarFiles
 	 * 			  List of jar file URLs to ship to the cluster
 	 * @return The result of the job execution, containing elapsed time and accumulators.
 	 */
-	protected JobExecutionResult executeRemotely(StreamGraph streamGraph, List<URL> jarFiles)
throws ProgramInvocationException {
+	public static JobExecutionResult executeRemotely(StreamExecutionEnvironment streamExecutionEnvironment,
 
 Review comment:
   This goes back a bit to the discussion on the ML. Remote execution shouldn't be an intrinsic
part of the environment, as regardless of which environment you're using it is still possible
to submit it remotely provided you have the host/port arguments.
   
   With how this PR sets things up you don't have to change your `getExecutionEnvironment`
call every time you want to change the submission method; instead you only replace the `execute()`
call which imo makes a lot more sense.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Ability to programmatically execute streaming pipeline with savepoint restore  
> -------------------------------------------------------------------------------
>
>                 Key: FLINK-11048
>                 URL: https://issues.apache.org/jira/browse/FLINK-11048
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>    Affects Versions: 1.7.0
>            Reporter: Thomas Weise
>            Assignee: Thomas Weise
>            Priority: Minor
>              Labels: pull-request-available
>
> RemoteStreamEnvironment.execute doesn't support restore from savepoint, though the underlying
ClusterClient does. Add an explicit "execute remotely" that can be used by downstream projects.
> [https://lists.apache.org/thread.html/6fff05d4a8444d1c6fa139d63605d51f610caff46605a4cdbb35cd50@%3Cdev.flink.apache.org%3E]
>  
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message