flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-11048) Ability to programmatically execute streaming pipeline with savepoint restore
Date Thu, 06 Dec 2018 13:38:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711449#comment-16711449
] 

ASF GitHub Bot commented on FLINK-11048:
----------------------------------------

mxm commented on a change in pull request #7249: [FLINK-11048] Ability to programmatically
execute streaming pipeline with savepoint restore
URL: https://github.com/apache/flink/pull/7249#discussion_r239452431
 
 

 ##########
 File path: flink-scala-shell/src/main/java/org/apache/flink/api/java/ScalaShellRemoteStreamEnvironment.java
 ##########
 @@ -68,30 +67,21 @@ public ScalaShellRemoteStreamEnvironment(
 		this.flinkILoop = flinkILoop;
 	}
 
-	/**
-	 * Executes the remote job.
-	 *
-	 * @param streamGraph
-	 *            Stream Graph to execute
-	 * @param jarFiles
-	 * 			  List of jar file URLs to ship to the cluster
-	 * @return The result of the job execution, containing elapsed time and accumulators.
-	 */
-	@Override
-	protected JobExecutionResult executeRemotely(StreamGraph streamGraph, List<URL> jarFiles)
throws ProgramInvocationException {
+	protected List<URL> getJarFiles() throws ProgramInvocationException {
 		URL jarUrl;
 		try {
 			jarUrl = flinkILoop.writeFilesToDisk().getAbsoluteFile().toURI().toURL();
 		} catch (MalformedURLException e) {
+			// TODO: we don't have the actual jobID at this point
 			throw new ProgramInvocationException("Could not write the user code classes to disk.",
-				streamGraph.getJobGraph().getJobID(), e);
+				new JobID(), e);
 
 Review comment:
   That will generate a random `JobID`, not sure about this. Let's use the constructor without
the JobID.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Ability to programmatically execute streaming pipeline with savepoint restore  
> -------------------------------------------------------------------------------
>
>                 Key: FLINK-11048
>                 URL: https://issues.apache.org/jira/browse/FLINK-11048
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>    Affects Versions: 1.7.0
>            Reporter: Thomas Weise
>            Assignee: Thomas Weise
>            Priority: Minor
>              Labels: pull-request-available
>
> RemoteStreamEnvironment.execute doesn't support restore from savepoint, though the underlying
ClusterClient does. Add an explicit "execute remotely" that can be used by downstream projects.
> [https://lists.apache.org/thread.html/6fff05d4a8444d1c6fa139d63605d51f610caff46605a4cdbb35cd50@%3Cdev.flink.apache.org%3E]
>  
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message