flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-11048) Ability to programmatically execute streaming pipeline with savepoint restore
Date Wed, 12 Dec 2018 05:25:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-11048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718478#comment-16718478
] 

ASF GitHub Bot commented on FLINK-11048:
----------------------------------------

tweise commented on a change in pull request #7249: [FLINK-11048] Ability to programmatically
execute streaming pipeline with savepoint restore
URL: https://github.com/apache/flink/pull/7249#discussion_r240885619
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/RemoteStreamEnvironment.java
 ##########
 @@ -169,33 +173,66 @@ public RemoteStreamEnvironment(String host, int port, Configuration
clientConfig
 		}
 	}
 
-	@Override
-	public JobExecutionResult execute(String jobName) throws ProgramInvocationException {
-		StreamGraph streamGraph = getStreamGraph();
-		streamGraph.setJobName(jobName);
-		transformations.clear();
-		return executeRemotely(streamGraph, jarFiles);
+	/**
+	 * Set savepoint restore settings that will be used when executing the job.
+	 * @param savepointRestoreSettings savepoint restore settings
+	 */
+	public void setSavepointRestoreSettings(SavepointRestoreSettings savepointRestoreSettings)
{
+		this.savepointRestoreSettings = savepointRestoreSettings;
 
 Review comment:
   Other than the job name all other execution parameters come from the "environment" already.
To me this is not a big deal as long as we don't introduce even more clutter than there already
is. Added another execute method instead. PTAL

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Ability to programmatically execute streaming pipeline with savepoint restore  
> -------------------------------------------------------------------------------
>
>                 Key: FLINK-11048
>                 URL: https://issues.apache.org/jira/browse/FLINK-11048
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>    Affects Versions: 1.7.0
>            Reporter: Thomas Weise
>            Assignee: Thomas Weise
>            Priority: Minor
>              Labels: pull-request-available
>
> RemoteStreamEnvironment.execute doesn't support restore from savepoint, though the underlying
ClusterClient does. Add an explicit "execute remotely" that can be used by downstream projects.
> [https://lists.apache.org/thread.html/6fff05d4a8444d1c6fa139d63605d51f610caff46605a4cdbb35cd50@%3Cdev.flink.apache.org%3E]
>  
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message