flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timo Walther (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (FLINK-11065) Migrate flink-table runtime classes
Date Fri, 07 Dec 2018 11:31:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-11065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711649#comment-16711649
] 

Timo Walther edited comment on FLINK-11065 at 12/7/18 11:30 AM:
----------------------------------------------------------------

[~hequn8128] Yes, I think runner classes are straight forward to port and can be grouped into
one issue. Helper classes as selectors and collectors as well.

We should try to not have more than 1000-1500 lines of ported Scala code per PR. The PR should
be reviewable. It would be terrible to introduce new bugs and threaten the stability of the
existing code base. I just wanted to mention again that we should have two commits with and
without ported tests to verify the porting. Feel free to create subtasks under this issue.

The module split is on my TODO list for next week, I will announce this on the mailing list.

As mentioned before, if there is a chance to deduplicate or simplify code, we should also
do this. 


was (Author: twalthr):
[~hequn8128] Yes, I think runner classes are straight forward to port and can be grouped into
one issue. Helper classes as selectors and collectors as well.

We should try to not have more than 1000-1500 lines of ported Scala code per PR. The PR should
be reviewable. It would be terrible to introduce new bugs and threaten the stability of the
existing code base. I just wanted to mention again that we should have two commits with and
without ported tests to verify the porting. Feel free to create subtasks under this issue.

The module split is on my TODO list for next week, I will announce this on the mailing list.

As mentioned before, if there is a chance to duplicate or simplify code, we should also do
this. 

> Migrate flink-table runtime classes
> -----------------------------------
>
>                 Key: FLINK-11065
>                 URL: https://issues.apache.org/jira/browse/FLINK-11065
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Priority: Major
>
> This issue covers the third step of the migration plan mentioned in [FLIP-28|https://cwiki.apache.org/confluence/display/FLINK/FLIP-28%3A+Long-term+goal+of+making+flink-table+Scala-free].
> All runtime classes have little dependencies to other classes.
> This issue tracks efforts of porting runtime classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message