flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-11069) Remove FutureUtil
Date Fri, 07 Dec 2018 03:12:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712288#comment-16712288

ASF GitHub Bot commented on FLINK-11069:

TisonKun edited a comment on issue #7245: [FLINK-11069] [utils] Remove FutureUtil
URL: https://github.com/apache/flink/pull/7245#issuecomment-445107203
   Thanks @yanghua.
   I notice the inconsistent among `util.function`. With 1e6a91a3bf7e734eccdb034ce505b3775b709265
@StephanEwen mark the functional interfaces in `util.function` as `@Public`, but the following
interfaces were not marked. Such a `unchecked` static method is proposed by @GJL.
   I prefer the idea to make the interfaces final, and thus think it could be a follow up
to refactor the static methods into `FunctionUtils`. Alternatively, for cohesion, add these
static methods into the corresponding interfaces and regards the currently `@Public` ones
are accidentally not final in the beginning.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Remove FutureUtil
> -----------------
>                 Key: FLINK-11069
>                 URL: https://issues.apache.org/jira/browse/FLINK-11069
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 1.8.0
>            Reporter: Till Rohrmann
>            Assignee: TisonKun
>            Priority: Minor
>              Labels: pull-request-available
> The utility class {{FutureUtil}} contains duplicate methods and method which are not
implemented optimally. I suggest to merge {{FutureUtil}} with {{FutureUtils}} and get rid
of the {{waitForAll}} method.

This message was sent by Atlassian JIRA

View raw message