flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-11069) Remove FutureUtil
Date Wed, 05 Dec 2018 12:01:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709978#comment-16709978
] 

ASF GitHub Bot commented on FLINK-11069:
----------------------------------------

TisonKun opened a new pull request #7245: [FLINK-11069] [utils] Remove FutureUtil
URL: https://github.com/apache/flink/pull/7245
 
 
   ## What is the purpose of the change
   
   The utility class `FutureUtil` contains duplicate methods and method which are not implemented
optimally. I suggest to merge `FutureUtil` with `FutureUtils` and get rid of the `waitForAll`
method.
   
   ## Brief change log
   
   - Remove `FutureUtil`
   - Merge `runIfNotDoneAndGet` into `FutureUtils`
   - Get rid of `waitForAll`. Instead use `FutureUtils#waitForAll`
   - Introduce `uncheck` static method in `SupplierWithException` for the adjustment
   
   
   ## Verifying this change
   
   This change is a trivial rework covering by the relevant tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (**no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**no**)
     - The serializers: (**no**)
     - The runtime per-record code paths (performance sensitive):(**no**)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (**no**)
     - The S3 file system connector: (**no**)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**no**)
     - If yes, how is the feature documented? (**not applicable**)
   
   cc @tillrohrmann 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove FutureUtil
> -----------------
>
>                 Key: FLINK-11069
>                 URL: https://issues.apache.org/jira/browse/FLINK-11069
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 1.8.0
>            Reporter: Till Rohrmann
>            Assignee: TisonKun
>            Priority: Minor
>              Labels: pull-request-available
>
> The utility class {{FutureUtil}} contains duplicate methods and method which are not
implemented optimally. I suggest to merge {{FutureUtil}} with {{FutureUtils}} and get rid
of the {{waitForAll}} method.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message