flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] godfreyhe commented on a change in pull request #8088: [FLINK-12073][table-planner-blink] Support appropriate precision and scale processing of Decimal
Date Mon, 01 Apr 2019 04:30:18 GMT
godfreyhe commented on a change in pull request #8088: [FLINK-12073][table-planner-blink] Support
appropriate precision and scale processing of Decimal
URL: https://github.com/apache/flink/pull/8088#discussion_r270713865
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/typeutils/BigDecimalTypeInfo.java
 ##########
 @@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.typeutils;
+
+import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.common.typeutils.base.BigDecComparator;
+import org.apache.flink.api.common.typeutils.base.BigDecSerializer;
+
+import java.math.BigDecimal;
+import java.util.Arrays;
+
+/**
+ * {@link TypeInformation} for {@link BigDecimal}.
+ *
+ * <p>It differs from {@link BasicTypeInfo#BIG_DEC_TYPE_INFO} in that:
+ * This type includes `precision` and `scale`, similar to SQL DECIMAL.
+ */
+public class BigDecimalTypeInfo extends BasicTypeInfo<BigDecimal> {
 
 Review comment:
   Please port BigDecimalTypeInfoTest in this PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message