flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zhijiangW opened a new pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment
Date Mon, 01 Apr 2019 06:55:23 GMT
zhijiangW opened a new pull request #8090: [FLINK-12067][network] Refactor the constructor
of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8090
 
 
   ## What is the purpose of the change
   
   *The constructor of `NetworkEnvironment` could be refactored to only contain `NetworkEnvironmentConfiguration`,
the other related components such as `TaskEventDispatcher`, `ResultPartitionManager`, `NetworkBufferPool`
could be created internally.*
   
   *We also refactor the process of generating `NetworkEnvironmentConfiguration` in `TaskManagerServiceConfiguration`
to add `numNetworkBuffers` instead of previous `networkBufFraction`, `networkBufMin`, `networkBufMax`.
This way seems more easy and direct to construct `NetworkBufferPool` later. `isCreditBased`
field is also maintained in this component for considering the setting usage in tests.*
   
   *Further we introduce the `NetworkEnvironmentConfigurationBuilder` for creating `NetworkEnvironmentConfiguration`
easily especially for tests.*
   
   ## Brief change log
   
     - *Refactor the constructor of `NetworkEnvironment` to container only `NetworkEnvironmentConfiguration*
     - *Refactor the constructor of `NetworkEnvironmentConfiguration`*
     - *Introduce the NetworkEnvironmentConfigurationBuilder` for tests*
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *NetworkEnvironmentTest* and
*NetworkBufferCalculationTest*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not
documented)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message