flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] tillrohrmann commented on a change in pull request #8002: [FLINK-11923][metrics] MetricRegistryConfiguration provides MetricReporters Suppliers
Date Mon, 08 Apr 2019 09:26:55 GMT
tillrohrmann commented on a change in pull request #8002: [FLINK-11923][metrics] MetricRegistryConfiguration
provides MetricReporters Suppliers
URL: https://github.com/apache/flink/pull/8002#discussion_r272950654
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
 ##########
 @@ -87,10 +86,14 @@
 
 	private boolean isShutdown;
 
+	public MetricRegistryImpl(MetricRegistryConfiguration config) {
+		this(config, Collections.emptyList());
+	}
+
 	/**
 	 * Creates a new MetricRegistry and starts the configured reporter.
 	 */
-	public MetricRegistryImpl(MetricRegistryConfiguration config) {
+	public MetricRegistryImpl(MetricRegistryConfiguration config, List<ReporterSetup>
reporterConfigurations) {
 
 Review comment:
   Could this be a `Collection<ReporterSetup>`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message