flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment
Date Mon, 08 Apr 2019 10:58:50 GMT
zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the
creation of ResultPartition and InputGate into NetworkEnvironment
URL: https://github.com/apache/flink/pull/7822#discussion_r272989781
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
 ##########
 @@ -88,6 +104,12 @@
 
 	private final boolean enableCreditBased;
 
+	private final boolean enableNetworkDetailedMetrics;
+
+	private final ConcurrentHashMap<String, ResultPartition[]> allPartitions;
 
 Review comment:
   Sorry for missing this comment before.
   
   Yes, I agree with the point of indexing by `executionId`, and use task name + id for debugging.
   My current thought is passing `ShuffleTaskInfo` into `ShuffleService` during creating partition/gate,
so #7835 would not be used any more. I would double check the details from the implementation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message