flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] twalthr commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions
Date Mon, 08 Apr 2019 16:19:50 GMT
twalthr commented on a change in pull request #8062:  [FLINK-11884][table] Implement expression
resolution on top of new Expressions
URL: https://github.com/apache/flink/pull/8062#discussion_r273119314
 
 

 ##########
 File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/stream/table/validation/CalcValidationTest.scala
 ##########
 @@ -47,67 +47,60 @@ class CalcValidationTest extends TableTestBase {
     .select('w.end.rowtime, 'int.count as 'int) // no rowtime on non-window reference
   }
 
-  @Test(expected = classOf[TableException])
+  @Test(expected = classOf[ValidationException])
   def testAddColumnsWithAgg(): Unit = {
     val util = streamTestUtil()
     val tab = util.addTable[(Int, Long, String)]("Table3",'a, 'b, 'c)
     tab.addColumns('a.sum)
   }
 
-  @Test(expected = classOf[TableException])
+  @Test(expected = classOf[ValidationException])
   def testAddOrReplaceColumnsWithAgg(): Unit = {
     val util = streamTestUtil()
     val tab = util.addTable[(Int, Long, String)]("Table3",'a, 'b, 'c)
     tab.addOrReplaceColumns('a.sum)
   }
 
-  @Test(expected = classOf[TableException])
+  @Test(expected = classOf[ValidationException])
   def testRenameColumnsWithAgg(): Unit = {
       val util = streamTestUtil()
       val tab = util.addTable[(Int, Long, String)]("Table3",'a, 'b, 'c)
       tab.renameColumns('a.sum)
   }
 
-  @Test(expected = classOf[TableException])
+  @Test(expected = classOf[ValidationException])
   def testRenameColumnsWithoutAlias(): Unit = {
     val util = streamTestUtil()
     val tab = util.addTable[(Int, Long, String)]("Table3",'a, 'b, 'c)
     tab.renameColumns('a)
   }
 
-  @Test(expected = classOf[TableException])
+  @Test(expected = classOf[ValidationException])
   def testRenameColumnsWithFunctallCall(): Unit = {
     val util = streamTestUtil()
     val tab = util.addTable[(Int, Long, String)]("Table3",'a, 'b, 'c)
     tab.renameColumns('a + 1  as 'a2)
   }
 
-  @Test(expected = classOf[TableException])
+  @Test(expected = classOf[ValidationException])
   def testRenameColumnsNotExist(): Unit = {
     val util = streamTestUtil()
     val tab = util.addTable[(Int, Long, String)]("Table3",'a, 'b, 'c)
     tab.renameColumns('e as 'e2)
   }
 
-  @Test(expected = classOf[TableException])
+  @Test(expected = classOf[ValidationException])
   def testDropColumnsWithAgg(): Unit = {
     val util = streamTestUtil()
     val tab = util.addTable[(Int, Long, String)]("Table3",'a, 'b, 'c)
     tab.dropColumns('a.sum)
   }
 
-  @Test(expected = classOf[TableException])
 
 Review comment:
   Isn't this test still valid?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message