flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] TisonKun commented on a change in pull request #7809: [FLINK-11710][tests] Refactor SimpleSlotProvider to TestingLogicalSlo…
Date Tue, 09 Apr 2019 13:08:40 GMT
TisonKun commented on a change in pull request #7809: [FLINK-11710][tests] Refactor SimpleSlotProvider
to TestingLogicalSlo…
URL: https://github.com/apache/flink/pull/7809#discussion_r273481356
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/instance/SettableSlotContext.java
 ##########
 @@ -26,9 +26,9 @@
 import org.apache.flink.util.Preconditions;
 
 /**
- * Simple implementation of the {@link SlotContext} interface for the legacy code.
+ * A settable implementation of the {@link SlotContext} interface.
  */
-public class SimpleSlotContext implements SlotContext {
+public class SettableSlotContext implements SlotContext {
 
 Review comment:
   It follows the convention implied by `SettableLeaderRetrievalService`. In fact, I'd prefer
move it to "test scope", whether rename or not is not quite important for me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message